Fix intermediate way point arrival not triggered#1908
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1908 +/- ##
============================================
+ Coverage 35.04% 35.94% +0.89%
- Complexity 1060 1076 +16
============================================
Files 261 261
Lines 8848 8853 +5
Branches 667 667
============================================
+ Hits 3101 3182 +81
+ Misses 5475 5383 -92
- Partials 272 288 +16 |
Guardiola31337
approved these changes
Apr 25, 2019
Contributor
Guardiola31337
left a comment
Guardiola31337
left a comment
There was a problem hiding this comment.
Looks good to me 🚢 🚢 @danesfeder and thanks!
This was referenced Apr 29, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1904
bug,feature,new API(s),SEMVER, etc.)Goal
Arrival state and listeners should be triggered for each way point along the route, not just the last one.
Implementation
Add a "previous"
NavigationStatusto the processor that allows us to look at the route state only after it's been passed to the developer in a listener.Screenshots or Gifs
Modified
NavigationLauncherActivityto allow way points for the passedDirectionsRoute:Testing
Please describe the manual tests that you ran to verify your changes
SNAPSHOTupstream dependencies if needed)Checklist